Typos batch: lib and include folders
#75020
Conversation
Sajjon
requested review from
AnthonyLatsis,
CodaFi,
DougGregor,
adrian-prantl,
ahoppen,
al45tair,
artemcm,
beccadax,
bnbarham,
eeckstein,
egorzhdan,
hamishknight,
hborla,
hyp,
ian-twilightcoder,
jckarter,
kavon,
rintaro,
rjmccall,
slavapestov,
tshortli,
xedin,
xymus and
zoecarver
as code owners
|
@swift-ci Please test |
|
@swift-ci Please test |
|
@swift-ci Please smoke test |
lib/SIL/IR/SILPrinter.cpp
Outdated
There was a problem hiding this comment.
@AnthonyLatsis should revert, right?
There was a problem hiding this comment.
You can change it, but in this case you have to change all occurrences in all test files, too. If you want to do this, I recommend to put those changes in a separate commit
There was a problem hiding this comment.
I would extract that change into a separate PR, this one is quite large already. If you choose to revert, please make sure to audit all modified occurrences.
There was a problem hiding this comment.
I'm leaving it as is.
There was a problem hiding this comment.
Then please put everything related to dynamically_replaceable in a separate commit, and make sure to modify all occurrences across the repository. Otherwise the tests will not pass, and we don’t want comments and documentation that mention this compiler attribute to be out-of-date.
There was a problem hiding this comment.
@AnthonyLatsis I've changed all occurrence to -> dynamically_replacable in separate commit: 08ba5a5
This comment has been minimized.
This comment has been minimized.
|
I feel uncomfortable with the size and contents of this patch. There are so many changes that none of the reviewers are going to read the entire patch, which would make it really easy for something slip through review here. Since none of these changes depend on each other, would you mind splitting this up into many smaller PRs that either all fix the same typo, or fix only typos in one directory so there's a smaller set of reviewers for each PR? |
7 participants
Fix typos to
libandincludefolders, as per suggestion by @compnerdIf valuable, I did split the work up initially, in my fork, in two PRs merged into this source branch, both of which, in turn was aggregated from several separate PRs.
lib/, merged from:lib/IRGenlib/Sema&lib/Refactoringlib/SILOptimizerlib/AST & lib/ASTGenlib/IDElib/sil&lib/SILGenlib/* (misc)include/, merged from:include/swift/SIL&include/swift/SILOptimizerinclude/swift/ASTinclude/*(misc)(most likely we wanna squash those 22 commits into a single one...)